shunping commented on code in PR #36034:
URL: https://github.com/apache/beam/pull/36034#discussion_r2319173650


##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/external_transforms.proto:
##########
@@ -76,6 +76,10 @@ message ManagedTransforms {
       "beam:schematransform:org.apache.beam:bigquery_write:v1"];
     ICEBERG_CDC_READ = 6 [(org.apache.beam.model.pipeline.v1.beam_urn) =
       "beam:schematransform:org.apache.beam:iceberg_cdc_read:v1"];
+    POSTGRES_READ = 7 [(org.apache.beam.model.pipeline.v1.beam_urn) =

Review Comment:
   Quick question: should I change the enum value to 8 and reserve 7 for 
ICEBERG_CDC_WRITE?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to