liferoad commented on code in PR #36060:
URL: https://github.com/apache/beam/pull/36060#discussion_r2325070647
##########
sdks/java/container/boot.go:
##########
@@ -227,19 +227,20 @@ func main() {
if pipelineOptions, ok :=
info.GetPipelineOptions().GetFields()["options"]; ok {
if heapDumpOption, ok :=
pipelineOptions.GetStructValue().GetFields()["enableHeapDumps"]; ok {
if heapDumpOption.GetBoolValue() {
- args = append(args, "-XX:+HeapDumpOnOutOfMemoryError",
-
"-Dbeam.fn.heap_dump_dir="+filepath.Join(dir, "heapdumps"),
- "-XX:HeapDumpPath="+filepath.Join(dir,
"heapdumps", "heap_dump.hprof"))
+ args = append(args,
"-XX:+HeapDumpOnOutOfMemoryError",
+
"-Dbeam.fn.heap_dump_dir="+filepath.Join(dir, "heapdumps"),
+ "-XX:HeapDumpPath="+filepath.Join(dir,
"heapdumps", "heap_dump.hprof"))
}
}
}
// Apply meta options
const metaDir = "/opt/apache/beam/options"
- // Note: Error is unchecked, so parsing errors won't abort container.
- // TODO: verify if it's intentional or not.
- metaOptions, _ := LoadMetaOptions(ctx, logger, metaDir)
+ metaOptions, err := LoadMetaOptions(ctx, logger, metaDir)
+ if err != nil {
+ logger.Fatalf(ctx, "LoadMetaOptions failed: %v", err)
Review Comment:
this should just log the error. I do not think we should fail container,
which could cause some breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
