sjvanrossum commented on PR #36075: URL: https://github.com/apache/beam/pull/36075#issuecomment-3264838090
> Partially revert changes to KafkaLatestOffsetEstimator, refreshing end offsets on a background thread is complicated to maintain. This is part of a series of PRs to simplify the poll loop in ReadFromKafkaDoFn. > > ------------------------ > > Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: > > - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. > - [ ] Update `CHANGES.md` with noteworthy changes. > - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > > See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). > > To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) > > GitHub Actions Tests Status (on master branch) > ------------------------------------------------------------------------------------------------ > [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) > [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) > [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) > [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) > > See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. > Note for reviewers, the next step for end offset estimation will be to replace the consumer with an admin client (and removing support for all Kafka client versions <2.6.0) and memoize the `KafkaFuture<ListOffsetsResult.ListOffsetsResultInfo>` returned for the partition result of a list offsets request instead of the final result. This will restore the background thread refresh mechanism, but the executing thread is an IO thread managed by the Kafka client library instead of the single threaded executor used before this change. The stress tests I run show that replacing the consumer with an admin client reduces memory usage by ~90% (~150MiB for the consumer, ~15MiB for the admin client). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
