shunping commented on PR #36069: URL: https://github.com/apache/beam/pull/36069#issuecomment-3282652454
As always, thank you so much your the review and detailed feedback! Given there are a few pieces in this PR: some pretty much standard (plumbing the trigger data from proto and defining trigger callbacks), while some can use some more thoughts (watermark advanced flag or the watermark hold) and may be handle in independent PRs. I would suggest splitting this PRs into different tasks, so it will make development, testing, and reviewing easy. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
