lostluck commented on code in PR #36137:
URL: https://github.com/apache/beam/pull/36137#discussion_r2345029487
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1153,6 +1153,7 @@ type stageState struct {
input mtime.Time // input watermark for the parallel input.
output mtime.Time // Output watermark for the whole stage
estimatedOutput mtime.Time // Estimated watermark output from DoFns
+ preRefreshedInput mtime.Time // input watermark before the last
watermark refresh
Review Comment:
Probably just "previousInput" is fine as a name. The concept is complicated
enough that it's not going to really fit into the variable name, we'll need
comments anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
