Abacn commented on code in PR #36138:
URL: https://github.com/apache/beam/pull/36138#discussion_r2349389859
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -1290,15 +1277,18 @@ public DataflowPipelineJob run(Pipeline pipeline) {
+ "related to Google Compute Engine usage and other Google Cloud
Services.");
DataflowPipelineOptions dataflowOptions =
options.as(DataflowPipelineOptions.class);
- String workerHarnessContainerImageURL =
DataflowRunner.getContainerImageForJob(dataflowOptions);
+ String v1WorkerContainerImageURL =
+ DataflowRunner.getV1WorkerContainerImageForJob(dataflowOptions);
+ String v2SdkHarnessContainerImageURL =
+ DataflowRunner.getV2SdkHarnessContainerImageForJob(dataflowOptions);
// This incorrectly puns the worker harness container image (which
implements v1beta3 API)
// with the SDK harness image (which implements Fn API).
//
// The same Environment is used in different and contradictory ways,
depending on whether
// it is a v1 or v2 job submission.
RunnerApi.Environment defaultEnvironmentForDataflow =
- Environments.createDockerEnvironment(workerHarnessContainerImageURL);
+ Environments.createDockerEnvironment(v2SdkHarnessContainerImageURL);
Review Comment:
Are the comments of this line (L1284-1290) still relevant (or need update)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
