claudevdm commented on code in PR #36090:
URL: https://github.com/apache/beam/pull/36090#discussion_r2353186065
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1664,7 +1664,7 @@ def with_exception_handling(
subject to change.
"""
args, kwargs = self.raw_side_inputs
- return self.label >> _ExceptionHandlingWrapper(
+ wrapper = self.label >> _ExceptionHandlingWrapper(
Review Comment:
Nice catch!
I still think the way this is implemented is confusing though, especially in
ptransform.py where the super class is checking a property defined on a
subclass _NamedPTransform
```
if hasattr(self, 'transform'):
self.transform.with_resource_hints(**kwargs)
```
We should just be able to implement with_resource_hints on _NamedPTransform
instead?
```
def with_resource_hints(self, **kwargs):
self.transform.with_resource_hints(**kwargs)
return self
```
I tried it on
https://github.com/apache/beam/compare/master...claudevdm:beam:resource-hints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
