claudevdm commented on code in PR #36184:
URL: https://github.com/apache/beam/pull/36184#discussion_r2359516983
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -4081,6 +4081,8 @@ def expand(self, pbegin):
# transforms (e.g. Write).
class MaybeReshuffle(PTransform):
+ side_inputs = ()
Review Comment:
I wonder if it is because MaybeReshuffle is defined dynamically (inside
Create.expand?) which is affecting the inheritince.
In general I think it is better to avoid dynamic types unless necessary.
What do you think about moving MaybeReshuffle to the top level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
