lostluck commented on code in PR #36188:
URL: https://github.com/apache/beam/pull/36188#discussion_r2361556636
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1195,10 +1204,11 @@ type stageKind interface {
// addPending handles adding new pending elements to the stage
appropriate for the kind.
addPending(ss *stageState, em *ElementManager, newPending []element) int
// buildEventTimeBundle handles building bundles for the stage per it's
kind.
- buildEventTimeBundle(ss *stageState, watermark mtime.Time) (toProcess
elementHeap, minTs mtime.Time, newKeys set[string], holdsInBundle
map[mtime.Time]int, schedulable bool, pendingAdjustment int)
+ buildEventTimeBundle(ss *stageState, watermark mtime.Time) (toProcess
elementHeap, minTs mtime.Time, newKeys set[string],
+ holdsInBundle map[mtime.Time]int, panesInBundle []bundlePane,
schedulable bool, pendingAdjustment int)
- // updatePane based on the stage state.
- updatePane(ss *stageState, pane typex.PaneInfo, w typex.Window,
keyBytes []byte) typex.PaneInfo
+ // getPane based on the stage state, element metadata, and bundle id.
Review Comment:
The main problem with 'getPane' as a name is that we do pass a pane in,
which doesn't usually go with the 'get' convention. It's slightly more correct
than 'updatePane' though.
getPaneOrDefault ? Then rename the input pane parameter to default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
