gemini-code-assist[bot] commented on PR #36216: URL: https://github.com/apache/beam/pull/36216#issuecomment-3313404021
## Summary of Changes Hello @kennknowles, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change that aimed to differentiate between container images for Dataflow V1 workers and V2 SDK harnesses. The reversion is necessary due to an identified service-side bug that prevents the proper utilization of this separation. Consequently, the system now treats both container image configuration options as referring to the same image, ensuring operational consistency and stability for Dataflow jobs. The `workerHarnessContainerImage` option is now deprecated in favor of `sdkContainerImage`. ### Highlights * **Reverted Container Image Separation**: The previous attempt to cleanly separate V1 worker and V2 SDK harness container image handling has been reverted due to an identified service-side bug that prevented its proper utilization. * **Unified Container Image Handling**: The `workerHarnessContainerImage` and `sdkContainerImage` options are now treated as aliases, with `sdkContainerImage` being the preferred option, and both are enforced to have the same value to ensure operational consistency. * **Deprecation of `workerHarnessContainerImage`**: The `workerHarnessContainerImage` option has been deprecated, and its Javadoc updated to encourage users to transition to `sdkContainerImage`. * **Consolidated Image Getter Logic**: Internal methods for determining the container image URL, name, and version have been consolidated into a single set of functions (e.g., `getContainerImageForJob`), removing explicit V1/V2 distinctions. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
