damccorm commented on code in PR #36298:
URL: https://github.com/apache/beam/pull/36298#discussion_r2383132412
##########
.github/workflows/beam_Publish_Docker_Snapshots.yml:
##########
@@ -70,6 +70,13 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
+ - name: Set docker_tag_list
+ run: |
+ if [[ "${{ github.ref }}" == "refs/heads/master" ]]; then
+ echo "DOCKER_TAG_LIST=${{ github.sha }},latest" >> $GITHUB_ENV
+ else
+ echo "DOCKER_TAG_LIST=${{ github.sha }}" >> $GITHUB_ENV
+ fi
Review Comment:
Can we update this to use the same conditional logic as the other workflow?
It seems cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
