Abacn commented on code in PR #36271: URL: https://github.com/apache/beam/pull/36271#discussion_r2392273067
########## CHANGES.md: ########## @@ -94,6 +94,10 @@ * PulsarIO has now changed support status from incomplete to experimental. Both read and writes should now minimally function (un-partitioned topics, without schema support, timestamp ordered messages for read) (Java) ([#36141](https://github.com/apache/beam/issues/36141)). +* (Python) Logical type and coder registry are saved for pipelines with `save_main_session` pipeline option enabled in Review Comment: I agree it becomes misleading naming, unfortunately this flag was named by implementation detail instead of what user want to achieve (states at submission session env are preserved job execution time). Here I want to un-break existing pipeline option setting. If user needs a new flag on upgrading their pipeline they can choose to add `--pickle_library=dill`. Probably one can add an alias "--save_beam_registries" and recommend for use for new users. Making it enabled all times is a step further and has risk of new breakages, though I haven't observe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
