damccorm commented on code in PR #35056:
URL: https://github.com/apache/beam/pull/35056#discussion_r2399567064
##########
sdks/python/apache_beam/runners/interactive/testing/integration/tests/screen_diff_test.py:
##########
@@ -28,7 +28,7 @@
@pytest.mark.timeout(300)
class DataFramesTest(BaseTestCase):
def __init__(self, *args, **kwargs):
- kwargs['golden_size'] = (1024, 10000)
+ # kwargs['golden_size'] = (1024, 10000)
Review Comment:
Is there context on this?
##########
sdks/python/setup.py:
##########
@@ -557,6 +557,20 @@ def get_portability_package_data():
'torch',
'transformers',
],
+ 'p313_ml_test': [
Review Comment:
Rather than adding a p3XX_ml_test version for every supported python
version, could we rename `p312_ml_test` to something like `ml_basic_test`? I
think `ml_test` is just this + dill and tensorflow-transform FWIW
##########
sdks/python/setup.py:
##########
@@ -557,6 +557,20 @@ def get_portability_package_data():
'torch',
'transformers',
],
+ 'p313_ml_test': [
Review Comment:
I know this is technically breaking, but I would be surprised if anyone is
depending on this directly (and we could call this out in CHANGES)
##########
sdks/python/test-suites/gradle.properties:
##########
@@ -23,34 +23,34 @@
# dataflow test-suites
# (TODO): https://github.com/apache/beam/issues/21971
# Add python 3.10 to dataflow test-suites
-dataflow_precommit_it_task_py_versions=3.9,3.12
+dataflow_precommit_it_task_py_versions=3.9,3.13
Review Comment:
Could be a follow up (non-blocking here) - it would be nice to refactor 3.9
and 3.13 into `max_py_version` and `min_py_version` variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
