tvalentyn commented on code in PR #36345:
URL: https://github.com/apache/beam/pull/36345#discussion_r2399717097


##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -1016,9 +1024,22 @@ def _should_force_use_dill():
 
 
 def _update_compatible_deterministic_fast_primitives_coder(coder, step_label):
-  if _should_force_use_dill():
+  """ Returns the update compatible version of DeterministicFastPrimitivesCoder
+   The differences are in how "special types" e.g. NamedTuples, Dataclasses are
+   deterministically encoded.
+
+   - In SDK version <= 2.67.0 dill is used to encode "special types"
+   - In SDK version 2.68.0 cloudpickle is used to encode "special types" with
+   absolute filepaths in code objects and dynamic functions.
+   - In SDK version 2.69.0 cloudpickle is used to encode "special types" with

Review Comment:
   (also feel free to write the explanatory comment once and reference it later 
in other docstrings, or move these tests into a separate file if it helps.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to