shunping commented on code in PR #36384:
URL: https://github.com/apache/beam/pull/36384#discussion_r2403572104
##########
runners/prism/java/build.gradle:
##########
@@ -86,9 +86,8 @@ def sickbayTests = [
'org.apache.beam.sdk.metrics.MetricsTest$CommittedMetricTests.testCommittedStringSetMetrics',
'org.apache.beam.sdk.metrics.MetricsTest$CommittedMetricTests.testCommittedGaugeMetrics',
- // negative WaitGroup counter when failing bundle
+ // Instead of 42, Prism got 84, which suggests two early panes of 42 are
fired.
Review Comment:
Yes. I think the previous negative WaitGroup counter masked the true error
in this test.
The interesting thing is that it has a sister test at
https://github.com/apache/beam/blob/1e973630e6738a101e3840585d7d2832419018ce/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyTest.java#L206,
which uses TestStream rather than stateful DoFn to generate the upstream data.
That test passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
