tvalentyn commented on code in PR #36518:
URL: https://github.com/apache/beam/pull/36518#discussion_r2433469057
##########
sdks/python/apache_beam/runners/worker/worker_status.py:
##########
@@ -281,7 +333,7 @@ def _log_lull_sampler_info(self, sampler_info, instruction):
' for PTransform{name=%s, state=%s}' % (step_name, state_name))
else:
step_name_log = ''
- stack_trace = self._get_stack_trace(sampler_info)
+ stack_trace = self._get_stack_trace(sampler_info.tracked_thread)
Review Comment:
yes, it is a namedtuple,
https://github.com/apache/beam/blob/abf1904759e4d0368061e832e261a5a8c052de2b/sdks/python/apache_beam/runners/worker/statesampler.py#L126
. I also got puzzled by it and dug up a pr ~6yrs ago where this line of code
was introduced and the rationale was 'just in case'.
Also, above
https://github.com/apache/beam/blob/abf1904759e4d0368061e832e261a5a8c052de2b/sdks/python/apache_beam/runners/worker/worker_status.py#L141
we have unprotected access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
