lostluck commented on code in PR #36538:
URL: https://github.com/apache/beam/pull/36538#discussion_r2440654524
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -245,7 +245,7 @@ func (wk *W) Logging(stream
fnpb.BeamFnLogging_LoggingServer) error {
attrs = append(attrs, slog.Group("customData",
grp...))
}
- if beamlog.LogLevel == "debug" {
+ if logconfig.LogLevel == "debug" {
Review Comment:
I wasn't as clear as I could be. Sorry about that. The issue is mostly
checking the global on *every* message, which makes a race conditions more
likely.
At this stage, we can use the global when initializing the field on a W
object as the default. A later changes could then make it a per-pipeline case
using the global default.
Even though it's unlikely to change *now* it might change in the *future*.
We would want a different mechanism to inject additional observability during
execution anyway, without a race condition risk, rather than assume there's
only one pipeline, and it's not looking at this line now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
