claudevdm commented on code in PR #36335: URL: https://github.com/apache/beam/pull/36335#discussion_r2402613708
########## sdks/python/apache_beam/utils/histogram.py: ########## @@ -20,6 +20,9 @@ import threading from collections import Counter +from apache_beam.portability.api import metrics_pb2 +from apache_beam.portability.api.org.apache.beam.model.pipeline.v1.metrics_pb2 import HistogramValue Review Comment: Is this import necessary? Looks like theres mixed use of `metrics_pb2.HistogramValue` and `HistogramValue`, maybe we can just use `metrics_pb2.HistogramValue` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
