stankiewicz commented on code in PR #36393:
URL: https://github.com/apache/beam/pull/36393#discussion_r2407828668
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2764,6 +2764,9 @@ def expand(self, input):
class ConvertToBeamRows(PTransform):
def __init__(self, schema, dynamic_destinations):
+ if not isinstance(schema,
+ (bigquery.TableSchema, bigquery.TableFieldSchema)):
+ schema = bigquery_tools.get_bq_tableschema(schema)
Review Comment:
I could remove it but
beam_row_from_dict is publicly used method so removing this if would be
potentially breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
