damccorm commented on code in PR #36346:
URL: https://github.com/apache/beam/pull/36346#discussion_r2409051114
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/internal/DataflowGroupByKey.java:
##########
@@ -117,6 +140,20 @@ public PCollection<KV<K, Iterable<V>>>
expand(PCollection<KV<K, V>> input) {
"the keyCoder of a DataflowGroupByKey must be deterministic", e);
}
+ PipelineOptions options = input.getPipeline().getOptions();
+ String gbekOveride = options.getGBEK();
+ if (!this.insideGBEK && gbekOveride != null &&
!gbekOveride.trim().isEmpty()) {
+ this.surroundsGBEK = true;
+ Secret hmacSecret = Secret.parseSecretOption(gbekOveride);
Review Comment:
Yeah, that's right - only the runtime environment will access the secret
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
