damccorm commented on code in PR #35949:
URL: https://github.com/apache/beam/pull/35949#discussion_r2435986465
##########
sdks/java/io/neo4j/src/main/java/org/apache/beam/sdk/io/neo4j/Neo4jIO.java:
##########
@@ -1088,6 +1164,209 @@ abstract Builder<ParameterT> setParametersFunction(
}
}
+ /**
+ * This is the class which handles the work behind the {@link
#writeUnwindWithResults()} method.
+ */
+ @AutoValue
+ public abstract static class WriteUnwindWithResults<ParameterT>
+ extends PTransform<PCollection<ParameterT>,
PCollection<Neo4jWriteStats>> {
+
+ abstract @Nullable SerializableFunction<Void, Driver>
getDriverProviderFn();
+
+ abstract @Nullable ValueProvider<SessionConfig> getSessionConfig();
+
+ abstract @Nullable ValueProvider<String> getCypher();
+
+ abstract @Nullable ValueProvider<String> getUnwindMapName();
+
+ abstract @Nullable ValueProvider<TransactionConfig> getTransactionConfig();
+
+ abstract @Nullable SerializableFunction<ParameterT, Map<String, Object>>
+ getParametersFunction();
+
+ abstract @Nullable ValueProvider<Long> getBatchSize();
Review Comment:
Yeah, in general I would recommend against new value providers because flex
templates are the better option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
