gemini-code-assist[bot] commented on PR #36515: URL: https://github.com/apache/beam/pull/36515#issuecomment-3403595066
## Summary of Changes Hello @chamikaramj, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Apache Beam ExpansionService by enabling managed transforms to leverage specific, pre-configured dependencies during their expansion. This change addresses a previous limitation where managed transforms could not utilize the YAML-based expansion service configuration for dependency management. By introducing a new pipeline option and refining the dependency resolution logic, the PR enhances the flexibility and control over the expansion environment for complex data pipelines, particularly for schema-aware transforms. ### Highlights * **Managed Transform Dependency Management**: Introduced a new pipeline option, `useConfigDependenciesForManaged`, which allows managed transforms to utilize specific dependencies defined in the YAML-based expansion service configuration during the expansion process. * **Mock Artifact Handling for Testing**: Added a `MOCK_ARTIFACT_PREFIX` in `Environments.java` and updated the `getArtifacts` method to recognize and handle mock artifacts for testing purposes, preventing them from being resolved as actual files. * **Expansion Service Configuration Loading**: The `ExpansionService` now prioritizes loading the expansion config file from `commandLineOptions` if it's not explicitly set in the `pipeline.getOptions()`. * **Schema Transform ID Resolution**: Enhanced the `TransformProvider` to correctly extract the `transform_identifier` from `ManagedSchemaTransform` payloads, ensuring proper identification for dependency lookup. * **Updated Expansion Service Configuration**: The `expansion_service_config.yml` has been updated to include new schema-aware transform IDs (e.g., Iceberg, Kafka, BigQuery, various databases) and their corresponding expansion service JARs, and JDBC-related schema transforms now correctly point to the Google Cloud Platform expansion service JAR. * **New Test Coverage**: Added new test cases in `ExpansionServiceSchemaTransformProviderTest` to validate the functionality of config-based dependency resolution for managed transforms. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
