kennknowles commented on code in PR #36524:
URL: https://github.com/apache/beam/pull/36524#discussion_r2433391202
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/BatchViewOverrides.java:
##########
@@ -1378,6 +1378,11 @@ public T getValue() {
return value;
}
+ @Override
+ public @Nullable Boolean isDraining() {
Review Comment:
Making this nullable might create annoyance downstream. Default to `false`?
I know this means that we cannot represent older SDKs where we "don't know"
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValue.java:
##########
@@ -52,6 +52,9 @@ public interface WindowedValue<T> {
@Nullable
Long getRecordOffset();
+ @Nullable
+ Boolean isDraining();
Review Comment:
Or is it nullable as a way to not encode it when it is false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
