robertwb commented on a change in pull request #12782:
URL: https://github.com/apache/beam/pull/12782#discussion_r488902538
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_test.py
##########
@@ -168,7 +168,8 @@ def test_invalid_json_neg_inf(self):
@unittest.skipIf(HttpError is None, 'GCP dependencies are not installed')
class TestBigQuerySource(unittest.TestCase):
def test_display_data_item_on_validate_true(self):
- source = beam.io.BigQuerySource('dataset.table', validate=True)
+ source = beam.io.BigQuerySource(
Review comment:
How many of these tests fail if we don't force the native source?
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools_test.py
##########
@@ -451,7 +451,9 @@ def test_read_from_table(self):
client.jobs.GetQueryResults.return_value =
bigquery.GetQueryResultsResponse(
jobComplete=True, rows=table_rows, schema=schema)
actual_rows = []
- with beam.io.BigQuerySource('dataset.table').reader(client) as reader:
+ with beam.io.BigQuerySource(
Review comment:
Could you file a JIRA to update these to not depend on the deprecated
source?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
