damccorm commented on code in PR #36453:
URL: https://github.com/apache/beam/pull/36453#discussion_r2426399500
##########
.github/workflows/beam_PreCommit_Python_Dill.yml:
##########
@@ -106,9 +106,9 @@ jobs:
arguments: |
-Pposargs="${{
contains(matrix.os, 'self-hosted') &&
- 'apache_beam/internal/ apache_beam/ml/ apache_beam/transforms/
apache_beam/typehints/ apache_beam/runners/portability/ -m (uses_dill and not
require_docker_in_docker)' ||
- 'apache_beam/internal/ apache_beam/ml/ apache_beam/transforms/
apache_beam/typehints/ apache_beam/runners/portability/ -m (uses_dill and
require_docker_in_docker)'
- }}" \
+ 'apache_beam/internal/pickler_test.py
apache_beam/io/gcp/bigquery_file_loads_test.py
apache_beam/options/pipeline_options_validator_test.py
apache_beam/transforms/combinefn_lifecycle_test.py
apache_beam/transforms/util_test.py apache_beam/transforms/ptransform_test.py
apache_beam/typehints/schemas_test.py
apache_beam/runners/portability/stager_test.py -m (uses_dill and not
require_docker_in_docker)' ||
+ 'apache_beam/internal/pickler_test.py
apache_beam/io/gcp/bigquery_file_loads_test.py
apache_beam/options/pipeline_options_validator_test.py
apache_beam/transforms/combinefn_lifecycle_test.py
apache_beam/transforms/util_test.py apache_beam/transforms/ptransform_test.py
apache_beam/typehints/schemas_test.py
apache_beam/runners/portability/stager_test.py -m (uses_dill and
require_docker_in_docker)'
Review Comment:
I think we should avoid doing this in CI - the downside here is that now
adding a test in a different file also requires updating the github config
(which you can't even do in the same PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
