shunping commented on code in PR #36538:
URL: https://github.com/apache/beam/pull/36538#discussion_r2437978476
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -245,7 +245,7 @@ func (wk *W) Logging(stream
fnpb.BeamFnLogging_LoggingServer) error {
attrs = append(attrs, slog.Group("customData",
grp...))
}
- if beamlog.LogLevel == "debug" {
+ if logconfig.LogLevel == "debug" {
Review Comment:
In the previous implementation, we have server logger and job logger, but
both are pointing to the default logger. I see TODOs over those lines.
https://github.com/apache/beam/blob/34a6f542a7fcf6536335be57b4dc69e4ddbd7cb8/sdks/go/pkg/beam/runners/prism/internal/jobservices/server.go#L78
https://github.com/apache/beam/blob/34a6f542a7fcf6536335be57b4dc69e4ddbd7cb8/sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go#L101
We can fix the TODO in this PR, but we will need to plumb either job logger
or server logger into different components (e.g. elementmanager), and replace
all general slog calls with server/job logger calls. (That also leads to a
question of when to use server logger and when to use job logger.)
Does this sound the right path to move forward? @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
