arunpandianp commented on code in PR #36417:
URL: https://github.com/apache/beam/pull/36417#discussion_r2409890844
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetDataStreamRequests.java:
##########
@@ -197,6 +197,9 @@ void notifySent() {
*/
void notifyFailed() {
failed = true;
+ for (QueuedRequest request : requests) {
Review Comment:
> Can you make sure it is ok with other cases?
Yes. All batches and queued requests are guarded by GprcGetDataStream.this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
