tvalentyn commented on code in PR #36367:
URL: https://github.com/apache/beam/pull/36367#discussion_r2430904987
##########
sdks/python/apache_beam/runners/worker/data_plane.py:
##########
@@ -854,6 +860,11 @@ def close(self):
channel.close()
self._data_channel_cache.clear()
+ def cleanup(self, instruction_id):
+ # type: (str) -> None
+ for channel in self._data_channel_cache.values():
Review Comment:
although we won't likely be hitting this race since we probably create all
channels relatively early
##########
sdks/python/apache_beam/runners/worker/data_plane.py:
##########
@@ -502,7 +502,7 @@ def _clean_receiving_queue(self, instruction_id):
instruction_id cannot be reused for new queue.
"""
with self._receive_lock:
- self._received.pop(instruction_id)
+ self._received.pop(instruction_id, None)
Review Comment:
done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
