claudevdm commented on code in PR #35904: URL: https://github.com/apache/beam/pull/35904#discussion_r2415015553
########## sdks/python/apache_beam/internal/cloudpickle/cloudpickle.py: ########## @@ -567,6 +577,11 @@ def _make_function(code, globals, name, argdefs, closure): return types.FunctionType(code, globals, name, argdefs, closure) +def _make_function_from_identifier(code_path, globals, name, argdefs, closure): Review Comment: Also will code_path be deterministic on all environments? Cant the code_path just be passed to _make_function_from_identifier through functools.partial so get_code_from_identifier does not have to be called again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
