gemini-code-assist[bot] commented on PR #36437: URL: https://github.com/apache/beam/pull/36437#issuecomment-3381268801
## Summary of Changes Hello @Amar3tto, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR updates the ML inference benchmarks README to include a detailed guide on how to add new ML benchmark pipelines. It also updates existing links and adds descriptions for new PyTorch and VLLM benchmarks. ### Highlights * **Intent**: This pull request aims to provide comprehensive documentation on how to add new Machine Learning (ML) benchmark pipelines to the project. It clarifies the process for developers looking to contribute new performance tests for ML inference. * **Changes**: The primary change is an update to the `sdks/python/apache_beam/testing/benchmarks/inference/README.md` file. This update includes: 1. **Updated Links:** Several outdated links related to performance dashboards and benchmark definitions have been corrected and updated. 2. **New Benchmark Descriptions:** Added detailed descriptions for two new ML benchmarks: 'PyTorch Sentiment Analysis DistilBERT base' and 'VLLM Gemma 2b Batch Performance on Tesla T4', including model, accelerator, host details, and links to their implementations. 3. **New Guide: 'How to add a new ML benchmark pipeline':** A detailed, step-by-step guide (9 steps) has been added. This guide covers the entire process from creating pipeline and benchmark implementations, configuring GitHub Actions, testing, verifying metrics in BigQuery, updating the website, to creating Looker content for performance visualization. * **Reviewer Activity**: No specific reviewer activity has been recorded or provided in the context for this pull request. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
