ahmedabu98 commented on code in PR #35737:
URL: https://github.com/apache/beam/pull/35737#discussion_r2388836109
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/PortableBigQueryDestinations.java:
##########
@@ -95,9 +112,12 @@ public TableDestination getTable(String destination) {
Long expirationMs = timePartitioningConfig.getExpirationMs();
Boolean requirePartitionFilter =
timePartitioningConfig.getRequirePartitionFilter();
- if (type == null) {
+ Set<String> allowedTypes = new HashSet<>(Arrays.asList("DAY", "HOUR",
"MONTH", "YEAR"));
Review Comment:
nit: this should be a final static class variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
