damccorm commented on code in PR #36528:
URL: https://github.com/apache/beam/pull/36528#discussion_r2445044742
##########
sdks/python/apache_beam/io/filebasedsink.py:
##########
@@ -205,6 +205,19 @@ def open_writer(self, init_result, uid):
# We also ensure there will be no collisions with uid and a
# (possibly unsharded) file_path_prefix and a (possibly empty)
# file_name_suffix.
+ from apache_beam.pvalue import EmptySideInput
Review Comment:
We can do this, but I think it represents a bug with prism's handling of
side inputs. In this case,
https://github.com/apache/beam/blob/af748d07a1a7ca244ff057554d68932c014d5eeb/sdks/python/apache_beam/io/iobase.py#L1173
hasn't executed, which means that `sink.initialize_write()` hasn't necessarily
been called yet, but this should be guaranteed for batch pipelines
So we should probably file a follow up issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
