tarun-google commented on code in PR #36564:
URL: https://github.com/apache/beam/pull/36564#discussion_r2445456797
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java:
##########
@@ -285,14 +285,17 @@ public void validate(@Nullable PipelineOptions
maybeOptions) {
PipelineOptions options = Preconditions.checkArgumentNotNull(maybeOptions);
// We will use a BigQuery load job -- validate the temp location.
String tempLocation;
- if (customGcsTempLocation == null || customGcsTempLocation.get() == null) {
+ if (customGcsTempLocation == null) {
tempLocation = options.getTempLocation();
} else {
if (!customGcsTempLocation.isAccessible()) {
// Can't perform verification in this case.
return;
+ } else if (Strings.isNullOrEmpty(customGcsTempLocation.get())) {
Review Comment:
The base implementation itself is a bit odd, It needs pipelineoptions from
inputPTransform, which is busted(https://github.com/apache/beam/issues/33074),
and then backs off to pipelineoptions from context during runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
