mohamedawnallah commented on code in PR #35467: URL: https://github.com/apache/beam/pull/35467#discussion_r2445475834
########## sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py: ########## @@ -297,7 +297,7 @@ def __init__( class MilvusEnrichmentTestHelper: @staticmethod def start_db_container( - image="milvusdb/milvus:v2.6.2", + image="milvusdb/milvus:v2.5.10", Review Comment: > Do we need this downgrade? Yes, the Milvus DB `v2.6.0` version requires the pymilvus client SDK to be `v2.6.0`. It appears that breaking changes were introduced in this version. This can be seen in Milvus release notes compatability matrix e.g https://milvus.io/docs/release_notes.md#v260 or https://pypi.org/project/pymilvus/ I attempted to use the same container (`milvusdb/milvus:v2.6.2`) with pymilvus `v2.5.10`, but the Milvus DB would hang. Upgrading pymilvus to `v2.6.X` is not currently feasible, as mentioned here https://github.com/apache/beam/pull/35467#issuecomment-3419796770, primarily due to compatibility issues with Beam's gRPC-related packages I saw also this changed from `v2.5.10` to `v2.6.2` in this PR (https://github.com/apache/beam/pull/36413) but it wasn't taking effect since it is overridden by: https://github.com/apache/beam/blob/07b321e5811af593eb37493b181c523c4e02c5a5/sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py#L484 > If yes, let's add a small comment explaining why this version is chosen. Added comments explaining why this version is chosen and how to upgrade it if feasible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
