kennknowles commented on code in PR #36524:
URL: https://github.com/apache/beam/pull/36524#discussion_r2453384501
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValue.java:
##########
@@ -52,6 +52,8 @@ public interface WindowedValue<T> {
@Nullable
Long getRecordOffset();
+ boolean isDraining();
Review Comment:
Nit: this might be named `causedByDrain` or `firedDueToDrain` or some way of
saying "element exists because of drain" or "element impacted by drain". I
don't have a good idea, really. But I couldn't help commenting, because
technically this is a piece of metadata about the element ("might be incomplete
because fired while draining"), not about the state of the world ("is
draining").
But I'm going to approve and merge anyhow, because it isn't worth kicking
all our flaky tests just to rename, unless we have a much better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
