liferoad commented on code in PR #36601:
URL: https://github.com/apache/beam/pull/36601#discussion_r2455678528
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/RecordWriter.java:
##########
@@ -72,12 +74,14 @@ class RecordWriter {
}
OutputFile outputFile;
EncryptionKeyMetadata keyMetadata;
- try (FileIO io = table.io()) {
- OutputFile tmpFile = io.newOutputFile(absoluteFilename);
- EncryptedOutputFile encryptedOutputFile =
table.encryption().encrypt(tmpFile);
- outputFile = encryptedOutputFile.encryptingOutputFile();
- keyMetadata = encryptedOutputFile.keyMetadata();
- }
+ // Keep FileIO open for the lifetime of this writer to avoid
+ // premature shutdown of underlying client pools (e.g., S3),
+ // which manifests as "Connection pool shut down" (Issue #36438).
+ this.io = table.io();
Review Comment:
@ahmedabu98 does this make sense to keep it open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
