damccorm commented on code in PR #36451:
URL: https://github.com/apache/beam/pull/36451#discussion_r2460594163
##########
sdks/python/container/common.gradle:
##########
@@ -53,7 +53,19 @@ def generatePythonRequirements =
tasks.register("generatePythonRequirements") {
"${files(configurations.sdkSourceTarball.files).singleFile} " +
"ml_image_requirements.txt " +
"container/ml " +
- "[gcp,dataframe,test,ml_cpu] " +
+ "[gcp,dataframe,test,tensorflow,torch,transformers] " +
+ "${pipExtraOptions}"
+ }
+ // GPU requirements not used for any containers directly due to licensing,
+ // but can be picked up by customers or other consumers for use.
+ exec {
+ executable 'sh'
+ args '-c', "cd ${rootDir} && ${runScriptsPath} " +
+ "${project.ext.pythonVersion} " +
+ "${files(configurations.sdkSourceTarball.files).singleFile} " +
+ "gpu_image_requirements.txt " +
+ "container/ml " +
+ "[gcp,dataframe,test,tensorflow,torch,transformers,vllm] " +
"${pipExtraOptions}"
}
Review Comment:
Lets revert the pieces inside sdks/python/container for now (this and
run_generate_requirements.sh) - they aren't working yet in a CI environment
##########
.github/workflows/refresh_looker_metrics.yml:
##########
@@ -19,26 +19,20 @@ name: Refresh Looker Performance Metrics
on:
workflow_dispatch:
- inputs:
- READ_ONLY:
- description: 'Run in read-only mode'
- required: false
- default: 'true'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LOOKERSDK_BASE_URL: ${{ secrets.LOOKERSDK_BASE_URL }}
LOOKERSDK_CLIENT_ID: ${{ secrets.LOOKERSDK_CLIENT_ID }}
LOOKERSDK_CLIENT_SECRET: ${{ secrets.LOOKERSDK_CLIENT_SECRET }}
GCS_BUCKET: 'public_looker_explores_us_a3853f40'
- READ_ONLY: ${{ inputs.READ_ONLY }}
Review Comment:
Is this related to the vllm pieces? Rather than removing it entirely, we
could also just flip the default to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
