shunping commented on code in PR #36610:
URL: https://github.com/apache/beam/pull/36610#discussion_r2461041541
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -791,8 +791,7 @@ func reElementResiduals(residuals []Residual, inputInfo
PColInfo, rb RunBundle)
panic("error decoding residual header:" + err.Error())
}
if len(ws) == 0 {
- slog.Error("reElementResiduals: sdk provided a windowed
value header 0 windows", "bundle", rb)
- panic("error decoding residual header: sdk provided a
windowed value header 0 windows")
+ slog.Warn("reElementResiduals: sdk provided a windowed
value header 0 windows", "bundle", rb)
Review Comment:
Dataflow and FnAPI runners all silently drop these events without even a
warning. Not sure if we want to handle that more differently prism.
On the other hand, we may add a warning message at the SDK side when a user
tries to initialize a sliding window with the slide interval longer than window
size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
