praneetnadella opened a new pull request, #36617:
URL: https://github.com/apache/beam/pull/36617
… True for cloudpickle
This change fixes a source of non-deterministic serialization in the Beam
Python SDK by ensuring that file paths associated with code objects
(`co_filename`) are normalized before being pickled by `cloudpickle`.
This PR implements path normalization by tying it to the existing
`enable_best_effort_determinism` flag in `cloudpickle_pickler.py`. When this
flag is enabled, a `filepath_interceptor` is used to replace the absolute path
with a deterministic, relative path.
Tested:
- Added `test_code_object_path_is_normalized`, a new unit test that
specifically verifies that a function's `co_filename` is correctly normalized
when the `enable_best_effort_determinism` flag is used.
- Updated `test_best_effort_determinism_not_implemented` (renamed to
`test_best_effort_determinism_is_partially_supported`) to check for the new,
more informative log message that is emitted when the flag is enabled.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
