kennknowles commented on code in PR #36615:
URL: https://github.com/apache/beam/pull/36615#discussion_r2462888740
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java:
##########
@@ -665,13 +666,13 @@ public void testSimpleCombine() {
}
@Test
- @Category({ValidatesRunner.class, UsesSideInputs.class})
+ @Category({ValidatesRunner.class, UsesSideInputs.class, BatchOnly.class})
public void testSimpleCombineEmpty() {
runTestSimpleCombine(EMPTY_TABLE, 0, Collections.emptyList());
}
@Test
- @Category({ValidatesRunner.class, UsesSideInputs.class})
+ @Category({ValidatesRunner.class, UsesSideInputs.class, BatchOnly.class})
Review Comment:
Since streaming and batch have really different execution models, I would
not opt this in to being batch only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
