gemini-code-assist[bot] commented on PR #36633:
URL: https://github.com/apache/beam/pull/36633#issuecomment-3450847395
## Summary of Changes
Hello @aIbrahiim, I'm Gemini Code Assist[^1]! I'm currently reviewing this
pull request and will post my feedback shortly. In the meantime, here's a
summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with the KafkaIO Python performance
test by making several crucial adjustments. It updates the Kubernetes
configurations for the underlying Kafka and Zookeeper clusters to ensure a more
robust and correctly provisioned test environment, primarily through increased
resource limits and improved readiness probes. Additionally, it refines the
Python test's assertion logic to be more resilient to minor variations in
message counts, ensuring the test accurately reflects successful data
processing.
### Highlights
* **Kafka Cluster Configuration Updates**: Updated Kubernetes configurations
for both Zookeeper and Kafka brokers, including increased resource allocations
(CPU and memory) and refined readiness probe settings to improve stability and
reliability of the test environment.
* **Kafka Broker JMX Port Streamlining**: The JMX port (5555) was removed
from the Kafka broker container configuration and its JMX_PORT environment
variable was set to "0", likely to streamline the test setup or avoid conflicts.
* **Python Performance Test Assertion Fix**: Modified the KafkaIO Python
performance test to assert that the total number of messages read is at least
the expected number, rather than strictly equal, accounting for potential
variations in test execution.
<details>
<summary><b>Ignored Files</b></summary>
* **Ignored by pattern:** `.github/workflows/**` (2)
* .github/workflows/beam_PerformanceTests_xlang_KafkaIO_Python.yml
* .github/workflows/beam_StressTests_Java_KafkaIO.yml
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation
page](https://developers.google.com/gemini-code-assist/docs/review-github-code),
here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment
using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a
summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull
request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current
pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged,
both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository
maintainers can create a configuration file and/or provide a custom code review
style guide (such as PEP-8 for Python) by creating and adding files to a
`.gemini/` folder in the base of the repository. Detailed instructions can be
found
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances
where its feedback is incorrect or counter productive. You can react with
:thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're
interested in giving your feedback about your experience with Gemini Code
Assist for Github and other Google products, sign up
[here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code
reviews directly in the IDE at no cost with the [Gemini Code Assist IDE
Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy),
[Generative AI Prohibited Use
Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of
Service](https://policies.google.com/terms), and learn how to configure Gemini
Code Assist in GitHub
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
Gemini can make mistakes, so double check it and [use code with
caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
