scwhittle commented on code in PR #36576:
URL: https://github.com/apache/beam/pull/36576#discussion_r2468774040
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/data/PCollectionConsumerRegistry.java:
##########
@@ -92,10 +92,23 @@ public static ConsumerAndMetadata forConsumer(
public abstract ExecutionStateTracker getExecutionStateTracker();
}
+ @AutoValue
+ abstract static class ExecutionStateKey {
+ public static ExecutionStateKey of(String pTransformId, String
pTransformUniqueName) {
+ return new AutoValue_PCollectionConsumerRegistry_ExecutionStateKey(
+ pTransformId, pTransformUniqueName);
+ }
+
+ public abstract String getPTransformId();
+
+ public abstract String getPTransformUniqueId();
+ }
+
private final ExecutionStateTracker stateTracker;
private final ShortIdMap shortIdMap;
- private final Map<String, List<ConsumerAndMetadata>>
pCollectionIdsToConsumers;
- private final Map<String, FnDataReceiver> pCollectionIdsToWrappedConsumer;
+ private final Map<String, List<ConsumerAndMetadata>>
pCollectionIdsToConsumers = new HashMap<>();
Review Comment:
Yes I think that some sort of PCollection registry could be better to
capture that, but punting for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
