mohamedawnallah commented on code in PR #36665:
URL: https://github.com/apache/beam/pull/36665#discussion_r2474424915


##########
sdks/python/setup.py:
##########
@@ -625,7 +625,6 @@ def get_portability_package_data():
           'Intended Audience :: End Users/Desktop',
           'License :: OSI Approved :: Apache Software License',
           'Operating System :: POSIX :: Linux',
-          'Programming Language :: Python :: 3.9',

Review Comment:
   While reviewing `sdks/python/setup.py`, I noticed two areas that might be 
relevant to our Python version update:
   
   1. The `python_requires = '>=3.9'` setting
   2. A dependency with a Python version constraint: 
`psycopg2-binary>=2.8.5,<2.9.10; python_version <= "3.9"`
   
   If we proceed with dropping Python 3.9 support, these would likely need 
updates:
   - `python_requires` would change to `'>=3.10'`
   - The `psycopg2-binary` py package constraint may need adjustment for 
`python_version >= "3.10"`
   
   Not sure though if updating this would require other ripple effect changes 
specifically for corresponding py packages upper/lower bound(s) for major/minor 
versions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to