lostluck commented on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-693700908
No worries. I assumed a conflict would happen somewhere. I'm just glad it was caught before merging. Supported/ignored labels/urns would be the way to go, but It does mean redundancy in the test cases making them a touch harder to add/maintain. This one was caught out since it's about a feature inside the schema coder spec that can't be detected by the base URN. Perhaps a new optional field? Most of them can be caught by the URNs themselves without special handling but it's the nested feature support that's trickier to work around (like Go looking up "logical" in the payload). On Wed, Sep 16, 2020, 3:26 PM Brian Hulette <[email protected]> wrote: > Sorry about that @lostluck <https://github.com/lostluck>, I should've let > you know about the new test case. There should probably be an easier way > for SDKs to temporarily opt out of particular tests. WDYT about giving each > suite labels that SDKs can use in an ignorelist? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/12588#issuecomment-693698195>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFOEGXV6FDCALZF6JNDSGE3Q5ANCNFSM4P73YZXQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
