kennknowles commented on a change in pull request #12540:
URL: https://github.com/apache/beam/pull/12540#discussion_r489808601



##########
File path: 
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java
##########
@@ -45,19 +45,16 @@
   void setBigQueryTable(@Nullable String tableName);
 
   @Description("InfluxDB measurement to publish results to.")
-  @Nullable
   String getInfluxMeasurement();
 
   void setInfluxMeasurement(@Nullable String measurement);
 
   @Description("InfluxDB host.")
-  @Nullable
   String getInfluxHost();
 
   void setInfluxHost(@Nullable String host);
 
   @Description("InfluxDB database.")
-  @Nullable

Review comment:
       Yes, exactly. I wonder if we can alter the core `PipelineOptions` code 
that generates the proxy objects to ensure that the nullability matches... (if 
you want an extra fun follow up project...)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to