tvalentyn opened a new pull request, #36704: URL: https://github.com/apache/beam/pull/36704
When more than one instance of the same PipelineOption subclass is detected, use the first one instead of the last one. This change helps to avoid a race condition where CloudPickle sometimes creates [skeleton classes] (https://github.com/apache/beam/blob/735864d4d5cd0abda9b1181c6459eb877218c16a/sdks/python/apache_beam/internal/cloudpickle/cloudpickle.py#L646C1-L647C1) and leaves then uninitiazlied, and eventually garbage collected. This happens when an initialized skeleton already exists for a given `class_tracker_id`. An uninitialized skeleton doesn't have an overloaded `PipelineOptionSubclass._add_argparse_args` bound method, and hence may cause difficult to debug error where pipeline options may not be properly parsed. Picking the first subclass empirically reduces the risk of picking the 'wrong' subclass, but a better fix would be to avoid creating uninitialized skeletons when they are not necessary to reduce sideeffects of unpickling. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
