derrickaw commented on code in PR #36641: URL: https://github.com/apache/beam/pull/36641#discussion_r2487819726
########## sdks/python/apache_beam/yaml/examples/transforms/blueprint/iceberg_to_iceberg_streaming.yaml: ########## @@ -0,0 +1,65 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# A pipeline that reads Append CDC events from Medallion Bronze Iceberg dataset +# and writes to Silver Iceberg dataset. + +pipeline: + type: chain + transforms: + # Step 1: Read CDC Append Records from Iceberg Table + - type: ReadFromIcebergCDC + name: ReadFromBronzeDataset + config: + table: "shipment_dataset_bronze.shipments" + catalog_name: "shipment_data" + catalog_properties: + type: "rest" + uri: "https://biglake.googleapis.com/iceberg/v1beta/restcatalog"; Review Comment: This is a good point. I think we need to consider that the golden blueprints that are used in the Dataflow templates repo have to be properly tested: Ideally, we should probably have: 1) One example blueprint that is properly filled out for users to use that has mock testing. 2) That same example blueprint that has jinja variable parameterization and has integration testing so that we know it works correctly. 3) Any additional transform testing for precommit or postcommits. What do you think about this: 1) Add a golden jinja yaml blueprint in the extended_tests/blueprints that we can use for both integration testing and for eventually linking in the Dataflow templates repo. 2) Create the examples blueprints based on these golden ones. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
