mohamedawnallah commented on code in PR #35708:
URL: https://github.com/apache/beam/pull/35708#discussion_r2493191292
##########
sdks/python/apache_beam/ml/rag/enrichment/milvus_search.py:
##########
@@ -104,44 +109,6 @@ def __str__(self):
return self.dict().__str__()
-@dataclass
-class MilvusConnectionParameters:
Review Comment:
> * Refactoring the enrichment pieces to use a class in the shared ingestion
component. This can also include any additional test refactoring (like you do
in enrichment_test.py)
Addressed this by making this PR include refactoring only (and also the
jupyter notebook to use the new data structures as result of refactoring)
> Adding the core functionality for this PR.
Added Milvus Sink Integration in that follow-up PR:
https://github.com/apache/beam/pull/36729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
