damccorm commented on PR #36722:
URL: https://github.com/apache/beam/pull/36722#issuecomment-3493165820

   > Nice find @alexmalao1. Could you include a test? Probably easiest to first 
put up a separate PR for adding the non-time-based custom window we've 
implemented and then creating a test using that
   
   +1 to adding a test, otherwise this LGTM though - thanks for the find


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to