sergiitk commented on code in PR #36528:
URL: https://github.com/apache/beam/pull/36528#discussion_r2501658416
##########
sdks/python/apache_beam/runners/worker/channel_factory.py:
##########
@@ -23,8 +23,12 @@
class GRPCChannelFactory(grpc.StreamStreamClientInterceptor):
DEFAULT_OPTIONS = [
- ("grpc.keepalive_time_ms", 20000),
- ("grpc.keepalive_timeout_ms", 300000),
+ # Default: 20000ms (20s), increased to 10 minutes for stability
Review Comment:
It's disabled by default, and unless you enable it, all other keepalive
settings you have (`grpc.keepalive_timeout_ms `,
`grpc.http2.max_pings_without_data`, `grpc.keepalive_permit_without_calls`)
have no effect.
##########
sdks/python/apache_beam/runners/worker/channel_factory.py:
##########
@@ -23,8 +23,12 @@
class GRPCChannelFactory(grpc.StreamStreamClientInterceptor):
DEFAULT_OPTIONS = [
- ("grpc.keepalive_time_ms", 20000),
- ("grpc.keepalive_timeout_ms", 300000),
+ # Default: 20000ms (20s), increased to 10 minutes for stability
Review Comment:
It's disabled by default, and unless you enable it, all other keepalive
settings you have (`grpc.keepalive_timeout_ms`,
`grpc.http2.max_pings_without_data`, `grpc.keepalive_permit_without_calls`)
have no effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
